third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp - Issue 2865373002: [Media, Controls] Cleanup resize observer before dereferencing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

Issue 2865373002: [Media, Controls] Cleanup resize observer before dereferencing. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

index 1dcaab2e60fbbf77e10a899b4957dc3cf730462e..eae7d34b38eb241a04817a7cd89d630ce49702a7 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp

@@ -443,7 +443,10 @@ void MediaControlsImpl::RemovedFrom(ContainerNode*) {

if (orientation_lock_delegate_)

orientation_lock_delegate_->Detach();

- resize_observer_.Clear();

+ if (resize_observer_) {

+ resize_observer_->disconnect();

+ resize_observer_.Clear();

+ }

}

void MediaControlsImpl::Reset() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »