Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2865253003: (Reland) Start using FileState/FileSystemState to provide consistent view. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

(Reland) Start using FileState/FileSystemState to provide consistent view. R=paulberry@google.com, sigmund@google.com BUG= Review-Url: https://codereview.chromium.org/2871783002 . Committed: https://github.com/dart-lang/sdk/commit/6e7d280a8358a845c42c2aa3b25b98cc8f7a105f

Patch Set 1 #

Patch Set 2 : New changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -20 lines) Patch
M pkg/front_end/lib/incremental_kernel_generator.dart View 1 chunk +3 lines, -5 lines 0 comments Download
A pkg/front_end/lib/src/incremental/file_state.dart View 1 chunk +225 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 5 chunks +50 lines, -4 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 3 chunks +19 lines, -11 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-09 15:28:24 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-09 15:34:13 UTC) #2
scheglov
3 years, 7 months ago (2017-05-09 16:04:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6e7d280a8358a845c42c2aa3b25b98cc8f7a105f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698