Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2865253002: Clean up MimeHandlerViewGuest. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up MimeHandlerViewGuest. Remove a bunch of unused bits, and simplify/clarify a couple snippets. of code. Review-Url: https://codereview.chromium.org/2865253002 Cr-Commit-Position: refs/heads/master@{#472038} Committed: https://chromium.googlesource.com/chromium/src/+/8b051cce47275c3f36acda2646197cc2a31d053e

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 6 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
Lei Zhang
3 years, 7 months ago (2017-05-09 18:51:47 UTC) #6
Sam McNally
lgtm
3 years, 7 months ago (2017-05-10 00:50:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865253002/1
3 years, 7 months ago (2017-05-10 04:54:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/432077)
3 years, 7 months ago (2017-05-10 05:22:54 UTC) #11
Lei Zhang
+fsamuel for OWNERS.
3 years, 7 months ago (2017-05-10 21:13:04 UTC) #13
Lei Zhang
+lazyboy - still looking for an OWNERS stamp.
3 years, 7 months ago (2017-05-15 22:41:54 UTC) #15
lazyboy
lgtm https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode276 extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:276: Destroy(/*also_delete=*/true); nit: add {}
3 years, 7 months ago (2017-05-15 22:53:29 UTC) #16
Lei Zhang
https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc#newcode276 extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:276: Destroy(/*also_delete=*/true); On 2017/05/15 22:53:29, lazyboy wrote: > nit: add ...
3 years, 7 months ago (2017-05-16 05:57:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865253002/20001
3 years, 7 months ago (2017-05-16 05:58:20 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 07:51:59 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b051cce47275c3f36acda264619...

Powered by Google App Engine
This is Rietveld 408576698