|
|
DescriptionClean up MimeHandlerViewGuest.
Remove a bunch of unused bits, and simplify/clarify a couple snippets.
of code.
Review-Url: https://codereview.chromium.org/2865253002
Cr-Commit-Position: refs/heads/master@{#472038}
Committed: https://chromium.googlesource.com/chromium/src/+/8b051cce47275c3f36acda2646197cc2a31d053e
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit, rebase #
Messages
Total messages: 27 (17 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thestig@chromium.org changed reviewers: + sammc@chromium.org
lgtm
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
thestig@chromium.org changed reviewers: + fsamuel@chromium.org
+fsamuel for OWNERS.
thestig@chromium.org changed reviewers: + lazyboy@chromium.org
+lazyboy - still looking for an OWNERS stamp.
lgtm https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_vi... File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_vi... extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:276: Destroy(/*also_delete=*/true); nit: add {}
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org, lazyboy@chromium.org Link to the patchset: https://codereview.chromium.org/2865253002/#ps20001 (title: "nit, rebase")
https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_vi... File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc (right): https://codereview.chromium.org/2865253002/diff/1/extensions/browser/guest_vi... extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:276: Destroy(/*also_delete=*/true); On 2017/05/15 22:53:29, lazyboy wrote: > nit: add {} Done.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494914272555780, "parent_rev": "d21c1862de12c2e3d59af90dd6cb0eb44f657108", "commit_rev": "8b051cce47275c3f36acda2646197cc2a31d053e"}
Message was sent while issue was closed.
Description was changed from ========== Clean up MimeHandlerViewGuest. Remove a bunch of unused bits, and simplify/clarify a couple snippets. of code. ========== to ========== Clean up MimeHandlerViewGuest. Remove a bunch of unused bits, and simplify/clarify a couple snippets. of code. Review-Url: https://codereview.chromium.org/2865253002 Cr-Commit-Position: refs/heads/master@{#472038} Committed: https://chromium.googlesource.com/chromium/src/+/8b051cce47275c3f36acda264619... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8b051cce47275c3f36acda264619... |