Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 2865243003: memory-infra: Rename Enable/Disable in MemoryDumpManager. (Closed)
Patch Set: fix commet Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager.h
diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h
index 6c71a247a68aad73f143ca5b9af3cd336574192d..9cadf3730ed3cbc3a37540fb414cc9aa9d85c5da 100644
--- a/base/trace_event/memory_dump_manager.h
+++ b/base/trace_event/memory_dump_manager.h
@@ -126,15 +126,14 @@ class BASE_EXPORT MemoryDumpManager {
void RequestGlobalDump(MemoryDumpType dump_type,
MemoryDumpLevelOfDetail level_of_detail);
- // Prepare MemoryDumpManager for RequestGlobalMemoryDump calls.
- // Starts the MemoryDumpManager thread.
- // Also uses the given config to initialize the peak detector,
- // scheduler and heap profiler.
- void Enable(const TraceConfig::MemoryDumpConfig&);
-
- // Tearsdown the MemoryDumpManager thread and various other state set up by
- // Enable.
- void Disable();
+ // Prepare MemoryDumpManager for RequestGlobalMemoryDump calls for tracing
+ // related modes (non-SUMMARY_ONLY).
+ // Initializes the peak detector, scheduler and heap profiler with the given
+ // config.
+ void SetupForTracing(const TraceConfig::MemoryDumpConfig&);
+
+ // Tear-down tracing related state.
Primiano Tucci (use gerrit) 2017/05/09 12:34:11 maybe just clarify in the comment that the all the
+ void TeardownForTracing();
// NOTE: Use RequestGlobalDump() to create memory dumps. Creates a memory dump
// for the current process and appends it to the trace. |callback| will be
« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698