components/autofill/content/renderer/provisionally_saved_password_form.h - Issue 2865233003: Use an MutationObserver to check when a password form disappears after XHR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/provisionally_saved_password_form.h

Issue 2865233003: Use an MutationObserver to check when a password form disappears after XHR (Closed)

Patch Set: updates Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/common/password_form.h » ('j') | third_party/WebKit/public/web/modules/password_manager/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/provisionally_saved_password_form.h

diff --git a/components/autofill/content/renderer/provisionally_saved_password_form.h b/components/autofill/content/renderer/provisionally_saved_password_form.h

index 177cf48fe3fa6426e646d230811827d1e11e8f0a..68af7b4f6933add6c1dbc89253d6bfe416adcac9 100644

--- a/components/autofill/content/renderer/provisionally_saved_password_form.h

+++ b/components/autofill/content/renderer/provisionally_saved_password_form.h

@@ -39,8 +39,8 @@ class ProvisionallySavedPasswordForm {

DCHECK(IsSet());

return *password_form_;

}

- const blink::WebFormElement& form_element() const { return form_element_; }

- const blink::WebInputElement& input_element() const { return input_element_; }

+ blink::WebFormElement& form_element() { return form_element_; }

+ blink::WebInputElement& input_element() { return input_element_; }

void SetSubmissionIndicatorEvent(

PasswordForm::SubmissionIndicatorEvent event);