Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2865233003: Use an MutationObserver to check when a password form disappears after XHR (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index b8f80e7f3807e64e90c32cc3fe552f6ac1fa63d0..f0ae52c68290a1055bed12ffdd5f48e75cdca6ef 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -147,6 +147,8 @@ class PasswordAutofillAgent : public content::RenderFrameObserver,
const blink::WebSecurityOrigin& origin);
private:
+ class FormElementObserver;
+
// Ways to restrict which passwords are saved in ProvisionallySavePassword.
enum ProvisionallySaveRestriction {
RESTRICTION_NONE,
@@ -258,7 +260,8 @@ class PasswordAutofillAgent : public content::RenderFrameObserver,
ProvisionallySaveRestriction restriction);
// Helper function called when same-document navigation completed
- void OnSameDocumentNavigationCompleted(bool is_inpage_navigation);
+ void OnSameDocumentNavigationCompleted(
+ PasswordForm::SubmissionIndicatorEvent event);
const mojom::AutofillDriverPtr& GetAutofillDriver();
@@ -308,6 +311,8 @@ class PasswordAutofillAgent : public content::RenderFrameObserver,
mojo::Binding<mojom::PasswordAutofillAgent> binding_;
+ FormElementObserver* form_element_observer_; // Weak reference.
+
DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
};

Powered by Google App Engine
This is Rietveld 408576698