Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

Issue 2865183003: Use the same design for all suggestions (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline@3x.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm b/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
index ff8a30abafeaa23a533f3293d8c469117a33d3c8..924dde3ee28cf526aa9906d860374a75e96feeda 100644
--- a/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
@@ -25,8 +25,8 @@
#import "ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.h"
#import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h"
#import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
-#import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h"
#import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_footer_item.h"
+#import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h"
#import "ios/chrome/browser/ui/icons/chrome_icon.h"
#import "ios/chrome/browser/ui/payments/cells/accepted_payment_methods_item.h"
#import "ios/chrome/browser/ui/payments/cells/autofill_profile_item.h"
@@ -339,7 +339,7 @@ const CGFloat kCardIssuerNetworkIconDimension = 25.0;
// Content Suggestions cells.
[model addSectionWithIdentifier:SectionIdentifierContentSuggestionsCell];
- [model addItem:[self contentSuggestionsArticleItem]
+ [model addItem:[self ContentSuggestionsItem]
toSectionWithIdentifier:SectionIdentifierContentSuggestionsCell];
[model addItem:[self contentSuggestionsFooterItem]
toSectionWithIdentifier:SectionIdentifierContentSuggestionsCell];
@@ -724,16 +724,15 @@ const CGFloat kCardIssuerNetworkIconDimension = 25.0;
return footerItem;
}
-- (ContentSuggestionsArticleItem*)contentSuggestionsArticleItem {
- ContentSuggestionsArticleItem* articleItem =
- [[ContentSuggestionsArticleItem alloc]
- initWithType:ItemTypeContentSuggestions
- title:@"This is an incredible article, you should read it!"
- subtitle:@"Really, this is the best article I have ever seen, it "
- @"is mandatory to read it! It describes how to write "
- @"the best article."
- delegate:nil
- url:GURL()];
+- (ContentSuggestionsItem*)ContentSuggestionsItem {
+ ContentSuggestionsItem* articleItem = [[ContentSuggestionsItem alloc]
+ initWithType:ItemTypeContentSuggestions
+ title:@"This is an incredible article, you should read it!"
+ subtitle:@"Really, this is the best article I have ever seen, it "
+ @"is mandatory to read it! It describes how to write "
+ @"the best article."
+ delegate:nil
+ url:GURL()];
articleItem.publisher = @"Top Publisher.com";
return articleItem;
}
« no previous file with comments | « ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_offline@3x.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698