ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm - Issue 2865183003: Use the same design for all suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

Issue 2865183003: Use the same design for all suggestions (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/reading_list/core/reading_list_entry.h ('k') | ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

diff --git a/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

index 211080966f4b62aaa0f23b19f839762df90c991a..8652fde94c6b28151d97628484c6e46877bb3ba7 100644

--- a/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

+++ b/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm

@@ -21,7 +21,7 @@

#import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"

#import "ios/chrome/browser/ui/commands/generic_chrome_command.h"

#include "ios/chrome/browser/ui/commands/ios_command_ids.h"

-#import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h"

+#import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_item.h"

#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h"

#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h"

#import "ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier.h"

@@ -48,7 +48,7 @@

- (void)openNewTabWithURL:(const GURL&)URL incognito:(BOOL)incognito;

// Dismisses the |article|, removing it from the content service, and dismisses

// the item at |indexPath| in the view controller.

-- (void)dismissArticle:(ContentSuggestionsArticleItem*)article

+- (void)dismissArticle:(ContentSuggestionsItem*)article

atIndexPath:(NSIndexPath*)indexPath;

@end

@@ -134,7 +134,7 @@

[self stop];

}

-- (void)displayContextMenuForArticle:(ContentSuggestionsArticleItem*)articleItem

+- (void)displayContextMenuForArticle:(ContentSuggestionsItem*)articleItem

atPoint:(CGPoint)touchLocation

atIndexPath:(NSIndexPath*)indexPath {

self.alertCoordinator = [[ActionSheetCoordinator alloc]

@@ -146,9 +146,9 @@

view:self.suggestionsViewController.collectionView];

__weak ContentSuggestionsCoordinator* weakSelf = self;

- GURL articleURL = articleItem.articleURL;

+ GURL articleURL = articleItem.URL;

NSString* articleTitle = articleItem.title;

- __weak ContentSuggestionsArticleItem* weakArticle = articleItem;

+ __weak ContentSuggestionsItem* weakArticle = articleItem;

NSString* openInNewTabTitle =

l10n_util::GetNSString(IDS_IOS_CONTENT_CONTEXT_OPENLINKNEWTAB);

@@ -230,7 +230,7 @@

[self stop];

}

-- (void)dismissArticle:(ContentSuggestionsArticleItem*)article

+- (void)dismissArticle:(ContentSuggestionsItem*)article

atIndexPath:(NSIndexPath*)indexPath {

if (!article)

return;