Use the same design for all suggestions

components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/reading_list/reading_list_suggestions_provider.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
 #include "components/ntp_snippets/category.h"
-#include "components/ntp_snippets/reading_list/reading_list_distillation_state_util.h"
 #include "components/reading_list/core/reading_list_entry.h"
 #include "components/reading_list/core/reading_list_model.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/url_formatter/url_formatter.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 
 namespace ntp_snippets {
 
 namespace {
@@ skipping 185 matching lines @@
   ContentSuggestion suggestion(provided_category_, entry->URL().spec(),
                                entry->URL());
 
   if (!entry->Title().empty()) {
     suggestion.set_title(base::UTF8ToUTF16(entry->Title()));
   } else {
     suggestion.set_title(url_formatter::FormatUrl(entry->URL()));
   }
   suggestion.set_publisher_name(
       url_formatter::FormatUrl(entry->URL().GetOrigin()));
+  int64_t entry_time =
+      entry->DistillationTime() / base::Time::kMicrosecondsPerSecond;

[Marc Treib, 2017/05/11 09:05:05]

Any reason DistillationTime is an int64 rather than a base::Time?

Generally, I'd recommend using the Time types as much as possible, and in
particular not doing any arithmetic on ints-that-represent-time, since that's
hard to read (IMO) and error prone.
Here you could do something like
Time::UnixEpoch() + TimeDelta::FromMicroseconds(DistillationTime())

[gambard, 2017/05/11 11:13:37]

I am not sure. The comment says "to avoid conversion". I have created a bug to
look more closely into it.

+  if (entry_time == 0) {

[Marc Treib, 2017/05/11 09:05:05]

Check DistillationTime() == 0 directly, before doing any arithmetic on it?

[gambard, 2017/05/11 11:13:37]

Done.

+    entry_time = entry->CreationTime() / base::Time::kMicrosecondsPerSecond;
+  }
+
+  suggestion.set_publish_date(base::Time::FromDoubleT(entry_time));
 
   auto extra = base::MakeUnique<ReadingListSuggestionExtra>();
-  extra->distilled_state =
-      SuggestionStateFromReadingListState(entry->DistilledState());
+  extra->distilled = entry->DistilledState() == ReadingListEntry::PROCESSED;
   extra->favicon_page_url =
       entry->DistilledURL().is_valid() ? entry->DistilledURL() : entry->URL();
   suggestion.set_reading_list_suggestion_extra(std::move(extra));
 
   return suggestion;
 }
 
 void ReadingListSuggestionsProvider::NotifyStatusChanged(
     CategoryStatus new_status) {
   if (category_status_ == new_status) {
     return;
   }
   category_status_ = new_status;
   observer()->OnCategoryStatusChanged(this, provided_category_, new_status);
 }
 
 void ReadingListSuggestionsProvider::SetDismissedState(const GURL& url,
                                                        bool dismissed) {
   reading_list::ContentSuggestionsExtra extra;
   extra.dismissed = dismissed;
   reading_list_model_->SetContentSuggestionsExtra(url, extra);
 }
 
 }  // namespace ntp_snippets