content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java - Issue 2865173002: Removing the unused child process ID parameter in ChildProcessLauncher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java

Issue 2865173002: Removing the unused child process ID parameter in ChildProcessLauncher. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | content/public/android/java/src/org/chromium/content/browser/ChildSpawnData.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java

index ffe74a84e797342f289df8919a88c76615808aef..3bf267069cf1781b17e9179ce36b7a5ce9bd50a7 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java

@@ -53,19 +53,18 @@ class ChildProcessLauncherHelper {

@CalledByNative

private static ChildProcessLauncherHelper create(long nativePointer, int paramId,

- final String[] commandLine, int childProcessId, FileDescriptorInfo[] filesToBeMapped) {

+ final String[] commandLine, FileDescriptorInfo[] filesToBeMapped) {

assert LauncherThread.runningOnLauncherThread();

- return new ChildProcessLauncherHelper(

- nativePointer, paramId, commandLine, childProcessId, filesToBeMapped);

+ return new ChildProcessLauncherHelper(nativePointer, paramId, commandLine, filesToBeMapped);

}

private ChildProcessLauncherHelper(long nativePointer, int paramId, final String[] commandLine,

- int childProcessId, FileDescriptorInfo[] filesToBeMapped) {

+ FileDescriptorInfo[] filesToBeMapped) {

assert LauncherThread.runningOnLauncherThread();

mNativeChildProcessLauncherHelper = nativePointer;

ChildProcessLauncher.start(ContextUtils.getApplicationContext(), paramId, commandLine,

- childProcessId, filesToBeMapped, new ChildProcessLauncher.LaunchCallback() {

+ filesToBeMapped, new ChildProcessLauncher.LaunchCallback() {

@Override

public void onChildProcessStarted(BaseChildProcessConnection connection) {

mChildProcessConnection = connection;