Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2865163002: Bump DEPS to linter `0.1.31`. (Closed)

Created:
3 years, 7 months ago by pquitslund
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump DEPS to linter `0.1.31`. Linter `0.1.31`: * New `prefer_foreach` lint. * New `use_string_buffers` rule. * New `unnecessary_overrides` rule. * New `join_return_with_assignment_when_possible` rule. * New `use_to_and_as_if_applicable` rule. * New `avoid_setters_without_getters` rule. * New `always_put_control_body_on_new_line` rule. * New `avoid_positional_boolean_parameters` rule. * New `always_require_non_null_named_parameters` rule. * New `prefer_conditional_assignment` rule. * New `prefer_conditional_assignment` rule. * New `avoid_types_on_closure_parameters` rule. * New `always_put_control_body_on_new_line` rule. * New `use_setters_to_change_properties` rule. * New `avoid_returning_this` rule. * New `avoid_annotating_with_dynamic_when_not_required` rule. * New `prefer_constructors_over_static_methods` rule. * New `avoid_returning_null` rule. * New `avoid_classes_with_only_static_members` rule. * New `avoid_null_checks_in_equality_operators` rule. * New `avoid_catches_without_on_clauses` rule. * New `avoid_catching_errors` rule. * New `use_rethrow_when_possible` rule. * Many lint fixes (notably `prefer_final_fields`, `unnecessary_lambdas`, `await_only_futures`, `cascade_invocations`, `avoid_types_on_closure_parameters`, and `overridden_fields`). * Significant performance improvements for `prefer_interpolation_to_compose_strings`. * New `unnecessary_this` rule. * New `prefer_initiliazling_formals` rule. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8fba8ccd978a5f8230fb18da0efee0ea53da943e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
3 years, 7 months ago (2017-05-08 19:48:29 UTC) #2
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-08 19:52:55 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as 8fba8ccd978a5f8230fb18da0efee0ea53da943e (presubmit successful).
3 years, 7 months ago (2017-05-08 19:53:58 UTC) #5
devoncarew
3 years, 7 months ago (2017-05-08 20:00:28 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698