Issue 286513002: Revert of Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286513002: Revert of Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. (Closed)

Created:
6 years, 7 months ago by danakj

Modified:
6 years, 7 months ago

Reviewers:
Ted C, aelias_OOO_until_Jul13

CC:
chromium-reviews, darin-cc_chromium.org, jam, enne (OOO), piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. (https://codereview.chromium.org/270933002/) Reason for revert: This is possibly breaking android telemetry pixel tests as per https://code.google.com/p/chromium/issues/detail?id=372562 Original issue's description: > Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback. > > The CompositeAndReadback is going away, and this method is thought to > be unused. Make the method just fail and return false. > > R=aelias, tedchoc@chromium.org > BUG=371592 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269448 TBR=aelias@chromium.org,tedchoc@chromium.org NOTREECHECKS=true NOTRY=true BUG=371592 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269894

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -1 line)			Patch
M	content/browser/android/content_view_render_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/android/content_view_render_view.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java	View	2 chunks	+13 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

danakj

Created Revert of Make ContentViewRenderView::CompositeToBitmap not CompositeAndReadback.

6 years, 7 months ago (2014-05-12 22:16:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/286513002/1

6 years, 7 months ago (2014-05-12 22:17:34 UTC) #2

Message was sent while issue was closed.

Change committed as 269894