Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2865017: Put Introspect method on the correct interface, (Closed)

Created:
10 years, 6 months ago by Nathan Williams
Modified:
9 years, 6 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/dhcpcd.git
Visibility:
Public.

Description

Put Introspect method on the correct interface, org.freedesktop.DBus.Introspectable (DBUS_INTERFACE_INTROSPECTABLE), not our local interface. Adjust the configuration file to allow use of this interface. TEST= dbus-send --system --print-reply --dest=... /org/chromium/dhcpcd org.freedesktop.DBus.Introspectable.Introspect dbus-send --system --print-reply --dest=... / org.freedesktop.DBus.Introspectable.Introspect

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M dhcpcd-dbus.c View 1 chunk +2 lines, -1 line 0 comments Download
M dhcpcd-dbus.conf View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nathan Williams
10 years, 6 months ago (2010-06-24 22:27:13 UTC) #1
Sam Leffler
10 years, 6 months ago (2010-06-24 22:51:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698