content/browser/accessibility/browser_accessibility_manager_unittest.cc - Issue 2864953002: Split out the MSCOM pieces of BrowserAccessibilityWin into a seperate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_unittest.cc

Issue 2864953002: Split out the MSCOM pieces of BrowserAccessibilityWin into a seperate class. (Closed)

Patch Set: follow up comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_com_win.cc ('k') | content/browser/accessibility/browser_accessibility_manager_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_unittest.cc b/content/browser/accessibility/browser_accessibility_manager_unittest.cc

index 0ac8677a475c1aff0b0818d670d17cb0339180d9..2f560445b18ab406b40777ac2e24931b82cd18b3 100644

--- a/content/browser/accessibility/browser_accessibility_manager_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_unittest.cc

@@ -38,15 +38,6 @@ class CountedBrowserAccessibility : public BrowserAccessibility {

int native_ref_count_;

static int global_obj_count_;

-#if defined(OS_WIN)

- // Adds some padding to prevent a heap-buffer-overflow when an instance of

- // this class is casted into a BrowserAccessibilityWin pointer.

- // http://crbug.com/235508

- // TODO(dmazzoni): Fix this properly.

- static const size_t kDataSize = sizeof(int) + sizeof(BrowserAccessibility);

- uint8_t padding_[sizeof(BrowserAccessibilityWin) - kDataSize];

-#endif

};

int CountedBrowserAccessibility::global_obj_count_ = 0;