Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2864913002: [TBR] Restore try/catch for FileSystemException in TranslateUri. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[TBR] Restore try/catch for FileSystemException in TranslateUri. I need to add exceptions to FileSystem and switch everything to FS. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/02c1a3bc54a12358d1e84ec9d97712e0f918323f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M pkg/front_end/lib/src/fasta/translate_uri.dart View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-07 02:48:17 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 02c1a3bc54a12358d1e84ec9d97712e0f918323f (presubmit successful).
3 years, 7 months ago (2017-05-07 02:55:37 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-07 14:18:36 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698