Update StreamTransformer documentation.

Update StreamTransformer documentation.

Fixes #29523.
BUG= http://dartbug.com/29523
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/c2ba323ad40acfe8220adce89c30da72f45e2446

[floitsch, 2017-05-06 15:46:56]

floitsch@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2017-05-08 07:08:55]

lgtm

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1653: * Example use of a duplicating transformer:
Example use of -> Example of use to create

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1672: *      cancelOnError: cancelOnError);
I find the formatting slightly confusing.
Try putting it in a file and run dartfmt on it (if you didn't already, but then
the confusion has a reason :)

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1680: * var duplicator = new StreamTransformer<int,
int>(_onListen);
Consider making it const, just because you can.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1680: * var duplicator = new StreamTransformer<int,
int>(_onListen);
Consider making it const, just because you can.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1710: * Returns a replacement stream for the provided
input [stream].
Returns a new stream with events that are computed from events of the provided
[stream].

(It's not a "replacement", it's just the result of a transformation)

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1725: * duration. Others might delay them not at all,
or just by a microtask.
delay them not at all -> not delay them at all

[floitsch, 2017-05-08 09:29:51]

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1653: * Example use of a duplicating transformer:
On 2017/05/08 07:08:55, Lasse Reichstein Nielsen wrote:
> Example use of -> Example of use to create

slightly changed.
done.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1672: *      cancelOnError: cancelOnError);
On 2017/05/08 07:08:54, Lasse Reichstein Nielsen wrote:
> I find the formatting slightly confusing.
> Try putting it in a file and run dartfmt on it (if you didn't already, but
then
> the confusion has a reason :)

Not much of a difference.
done.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1680: * var duplicator = new StreamTransformer<int,
int>(_onListen);
On 2017/05/08 07:08:54, Lasse Reichstein Nielsen wrote:
> Consider making it const, just because you can.

Done.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1680: * var duplicator = new StreamTransformer<int,
int>(_onListen);
On 2017/05/08 07:08:54, Lasse Reichstein Nielsen wrote:
> Consider making it const, just because you can.

Acknowledged.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1710: * Returns a replacement stream for the provided
input [stream].
On 2017/05/08 07:08:55, Lasse Reichstein Nielsen wrote:
> Returns a new stream with events that are computed from events of the provided
> [stream].
> 
> (It's not a "replacement", it's just the result of a transformation)

Done.

https://codereview.chromium.org/2864863002/diff/40001/sdk/lib/async/stream.da...
sdk/lib/async/stream.dart:1725: * duration. Others might delay them not at all,
or just by a microtask.
On 2017/05/08 07:08:55, Lasse Reichstein Nielsen wrote:
> delay them not at all -> not delay them at all

Done.

[floitsch, 2017-05-08 09:29:55]

Description was changed from

==========
Update StreamTransformer documentation.

Fixes #29523.
BUG= http://dartbug.com/29523
==========

to

==========
Update StreamTransformer documentation.

Fixes #29523.
BUG= http://dartbug.com/29523
R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c2ba323ad40acfe8220adce89c30da72f45e2446
==========

[floitsch, 2017-05-08 09:29:56]

Committed patchset #4 (id:60001) manually as
c2ba323ad40acfe8220adce89c30da72f45e2446 (presubmit successful).