Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2864833002: Tapping handle shouldn't select misspelled word (Closed)
Patch Set: Fixed naming Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 85aa0c06f3c9cba37e12e2f60dd74189df73e244..6dfd2d0fe9a503f97360087ffc4ebec7720159f4 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -1811,7 +1811,8 @@ static bool ShouldShowContextMenuAtSelection(const FrameSelection& selection) {
}
WebInputEventResult EventHandler::ShowNonLocatedContextMenu(
- Element* override_target_element) {
+ Element* override_target_element,
+ WebMenuSourceType source_type) {
FrameView* view = frame_->View();
if (!view)
return WebInputEventResult::kNotHandled;
@@ -1892,7 +1893,10 @@ WebInputEventResult EventHandler::ShowNonLocatedContextMenu(
WebFloatPoint(location_in_root_frame.X(), location_in_root_frame.Y()),
WebFloatPoint(global_position.X(), global_position.Y()),
WebPointerProperties::Button::kNoButton, /* clickCount */ 0,
- WebInputEvent::kNoModifiers, TimeTicks::Now().InSeconds());
+ ((source_type == kMenuSourceTouchHandle)
+ ? WebInputEvent::kIsCompatibilityEventForTouch
+ : WebInputEvent::kNoModifiers),
+ TimeTicks::Now().InSeconds());
// TODO(dtapuska): Transition the mouseEvent to be created really in viewport
// coordinates instead of root frame coordinates.
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.h ('k') | third_party/WebKit/Source/core/input/EventHandlerTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698