third_party/WebKit/Source/core/editing/SelectionController.cpp - Issue 2864833002: Tapping handle shouldn't select misspelled word

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2864833002: Tapping handle shouldn't select misspelled word (Closed)

Patch Set: Fixed naming Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp

index 89f86731d3aaf003d5e9eb34faa355a18c0d09de..2b5b1d6877417d9c9be5f00aa10b477e1848edb9 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp

@@ -1047,7 +1047,8 @@ void SelectionController::SendContextMenuEvent(

AutoReset<bool> mouse_down_may_start_select_change(

&mouse_down_may_start_select_, true);

- if (HitTestResultIsMisspelled(mev.GetHitTestResult()))

+ if (!mev.Event().FromTouch() &&

+ HitTestResultIsMisspelled(mev.GetHitTestResult()))

return SelectClosestMisspellingFromMouseEvent(mev);

if (!frame_->GetEditor().Behavior().ShouldSelectOnContextualMenuClick())