content/browser/renderer_host/input/touch_selection_controller_client_aura.cc - Issue 2864833002: Tapping handle shouldn't select misspelled word

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

Issue 2864833002: Tapping handle shouldn't select misspelled word (Closed)

Patch Set: Fixed naming Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touch_emulator_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

index d9d142aa834341bcda966ca450633630589e0571..8fb31d7467474617d29b7f3414161fac59e3cafa 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

@@ -466,9 +466,8 @@ void TouchSelectionControllerClientAura::RunContextMenu() {

gfx::PointF(anchor_rect.CenterPoint().x(), anchor_rect.y());

RenderWidgetHostImpl* host =

RenderWidgetHostImpl::From(rwhva_->GetRenderWidgetHost());

- host->Send(new ViewMsg_ShowContextMenu(host->GetRoutingID(),

- ui::MENU_SOURCE_TOUCH_EDIT_MENU,

- gfx::ToRoundedPoint(anchor_point)));

+ host->ShowContextMenuAtPoint(gfx::ToRoundedPoint(anchor_point),

+ ui::MENU_SOURCE_TOUCH_EDIT_MENU);

// Hide selection handles after getting rect-between-bounds from touch

// selection controller; otherwise, rect would be empty and the above