Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2864833002: Tapping handle shouldn't select misspelled word (Closed)
Patch Set: fixed bokan's nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | third_party/WebKit/public/web/WebMenuSourceType.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index 89f86731d3aaf003d5e9eb34faa355a18c0d09de..83362c8305e04eee4226f6e287da66ccc37e856d 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -1047,7 +1047,8 @@ void SelectionController::SendContextMenuEvent(
AutoReset<bool> mouse_down_may_start_select_change(
&mouse_down_may_start_select_, true);
- if (HitTestResultIsMisspelled(mev.GetHitTestResult()))
+ if (HitTestResultIsMisspelled(mev.GetHitTestResult()) &&
yosin_UTC9 2017/05/24 05:08:38 It is better to check |FromTouch()| before calling
amaralp1 2017/05/24 05:33:27 Done.
+ !mev.Event().FromTouch())
return SelectClosestMisspellingFromMouseEvent(mev);
if (!frame_->GetEditor().Behavior().ShouldSelectOnContextualMenuClick())
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | third_party/WebKit/public/web/WebMenuSourceType.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698