Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2864833002: Tapping handle shouldn't select misspelled word (Closed)
Patch Set: Mac test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 4d30cc70108004e1293246bc4584406ae55a5acd..19b856a7ff5174ca01d24a7462c03f9e108416d6 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -83,6 +83,7 @@
#include "ui/android/window_android.h"
#include "ui/android/window_android_compositor.h"
#include "ui/base/layout.h"
+#include "ui/base/ui_base_types.h"
#include "ui/events/android/motion_event_android.h"
#include "ui/events/base_event_utils.h"
#include "ui/events/blink/blink_event_util.h"
@@ -1857,7 +1858,7 @@ void RenderWidgetHostViewAndroid::MoveCaret(const gfx::Point& point) {
void RenderWidgetHostViewAndroid::ShowContextMenuAtPoint(
const gfx::Point& point) {
if (host_)
- host_->ShowContextMenuAtPoint(point);
+ host_->ShowContextMenuAtPoint(point, ui::MENU_SOURCE_TOUCH_HANDLE);
bokan 2017/05/23 14:06:02 Could we plumb this value up so that we specify TO
amaralp 2017/05/23 19:37:53 I changed the name of the functions from ShowConte
bokan 2017/05/24 18:28:22 Acknowledged.
}
void RenderWidgetHostViewAndroid::DismissTextHandles() {

Powered by Google App Engine
This is Rietveld 408576698