Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 286483004: Merge 269345 "[FileAPI] Clean up WebFileSystemImpl before Blink ..." (Closed)

Created:
6 years, 7 months ago by tzik
Modified:
6 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Merge 269345 "[FileAPI] Clean up WebFileSystemImpl before Blink ..." > [FileAPI] Clean up WebFileSystemImpl before Blink shutdown > > WebFileSystemImpl should not outlive V8 instance, since it may have references to V8. > This CL ensures it deleted before Blink shutdown. > > BUG=369525 > > Review URL: https://codereview.chromium.org/270633009 TBR=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/child_thread.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tzik
6 years, 7 months ago (2014-05-13 02:41:28 UTC) #1
tzik
6 years, 7 months ago (2014-05-13 02:42:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r269974.

Powered by Google App Engine
This is Rietveld 408576698