Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2864813002: Switch the default from non-driver to driver in several tests (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch the default from non-driver to driver in several tests R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6b8a56cd7f1458e4d0cd5915a892982dd0f0d599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -120 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/field_formal_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/label_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_prefix_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_library_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/variable_name_contributor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +1 line, -6 lines 0 comments Download
M pkg/analysis_server/test/services/correction/organize_directives_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/sort_members_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/util_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/index/index_unit_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
There are a few tests (in this class hierarchy) that don't pass when using the ...
3 years, 7 months ago (2017-05-05 23:58:34 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-06 00:12:20 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-07 15:34:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6b8a56cd7f1458e4d0cd5915a892982dd0f0d599 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698