Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: components/sync/model_impl/processor_entity_tracker.h

Issue 2864713002: [USS] Add function for update storage key for processor (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/model_impl/processor_entity_tracker.h
diff --git a/components/sync/model_impl/processor_entity_tracker.h b/components/sync/model_impl/processor_entity_tracker.h
index 7a9bf213f82e64069ab61924b8e3fee3aac8807b..6e3efd4ca885d6436d38fc823dbf7f7d0c50b85b 100644
--- a/components/sync/model_impl/processor_entity_tracker.h
+++ b/components/sync/model_impl/processor_entity_tracker.h
@@ -100,6 +100,12 @@ class ProcessorEntityTracker {
// Clears any in-memory sync state associated with outstanding commits.
void ClearTransientSyncState();
+ // Update storage_key_.
+ // This function should only be called by
+ // ModelTypeChangeProcessor::UpdateStorageKey for the data type which will not
pavely 2017/05/09 00:49:24 will not => does not base on => based on
Gang Wu 2017/05/09 22:33:15 Done.
+ // create storage key base on syncer::EntityData.
+ void SetStorageKey(const std::string& new_key);
+
// Takes the passed commit data updates its fields with values from metadata
// and caches it in the instance. The data is swapped from the input struct
// without copying.
@@ -139,7 +145,7 @@ class ProcessorEntityTracker {
void UpdateSpecificsHash(const sync_pb::EntitySpecifics& specifics);
// Storage key. Should always be available.
- const std::string storage_key_;
+ std::string storage_key_;
// Serializable Sync metadata.
sync_pb::EntityMetadata metadata_;

Powered by Google App Engine
This is Rietveld 408576698