Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2864653002: Attempt to fix failures on Windows bots (TBR) (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Attempt to fix failures on Windows bots (TBR) Committed: https://github.com/dart-lang/sdk/commit/eecb358dd4daaca18045f790b572d5527ad4a916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M pkg/analyzer_plugin/test/src/utilities/change_builder/change_builder_dart_test.dart View 54 chunks +54 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I find it somewhat disturbing that these test didn't fail before I moved the tests ...
3 years, 7 months ago (2017-05-05 15:52:46 UTC) #2
Brian Wilkerson
Committed patchset #1 (id:1) manually as eecb358dd4daaca18045f790b572d5527ad4a916 (presubmit successful).
3 years, 7 months ago (2017-05-05 15:53:05 UTC) #4
scheglov
3 years, 7 months ago (2017-05-05 15:53:27 UTC) #5
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698