Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_property_apis.py

Issue 2864583002: Added generated class level comments to all CSSPropertyAPIs. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_css_property_apis.py
diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_apis.py b/third_party/WebKit/Source/build/scripts/make_css_property_apis.py
index d94aa915df8e1049ce498d89d3d51508441a04bd..1b9448cd3242fd12856b25de0c985cd2d490ec32 100755
--- a/third_party/WebKit/Source/build/scripts/make_css_property_apis.py
+++ b/third_party/WebKit/Source/build/scripts/make_css_property_apis.py
@@ -78,7 +78,7 @@ class CSSPropertyAPIWriter(StyleBuilderWriter):
# This list contains duplicate entries, but is only used to check if a method is
# implemented for an api_class.
self.methods_for_classes[classname] += property_['api_methods']
- self._outputs[classname + '.h'] = self.generate_property_api_h_builder(classname)
+ self._outputs[classname + '.h'] = self.generate_property_api_h_builder(classname, property_['name'])
# Stores a list of classes with elements (index, classname, [propertyIDs, ..], [api_methods, ...]).
self._api_classes = []
@@ -124,11 +124,12 @@ class CSSPropertyAPIWriter(StyleBuilderWriter):
}
# Provides a function object given the classname of the property.
- def generate_property_api_h_builder(self, api_classname):
+ def generate_property_api_h_builder(self, api_classname, property_name):
@template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl')
def generate_property_api_h():
return {
'api_classname': api_classname,
+ 'property_name': property_name,
'methods_for_class': self.methods_for_classes[api_classname],
'all_api_methods': self.all_api_methods,
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698