Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: components/update_client/update_client.cc

Issue 2864573003: Revert of Initialize libxml to observe effects on the Android crash. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/update_client/update_client.h" 5 #include "components/update_client/update_client.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <queue> 8 #include <queue>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 18 matching lines...) Expand all
29 #include "components/update_client/persisted_data.h" 29 #include "components/update_client/persisted_data.h"
30 #include "components/update_client/ping_manager.h" 30 #include "components/update_client/ping_manager.h"
31 #include "components/update_client/task_send_uninstall_ping.h" 31 #include "components/update_client/task_send_uninstall_ping.h"
32 #include "components/update_client/task_update.h" 32 #include "components/update_client/task_update.h"
33 #include "components/update_client/update_checker.h" 33 #include "components/update_client/update_checker.h"
34 #include "components/update_client/update_client_errors.h" 34 #include "components/update_client/update_client_errors.h"
35 #include "components/update_client/update_client_internal.h" 35 #include "components/update_client/update_client_internal.h"
36 #include "components/update_client/update_engine.h" 36 #include "components/update_client/update_engine.h"
37 #include "components/update_client/update_response.h" 37 #include "components/update_client/update_response.h"
38 #include "components/update_client/utils.h" 38 #include "components/update_client/utils.h"
39 #include "third_party/libxml/src/include/libxml/parser.h"
40 #include "url/gurl.h" 39 #include "url/gurl.h"
41 40
42 namespace update_client { 41 namespace update_client {
43 42
44 CrxUpdateItem::CrxUpdateItem() : state(ComponentState::kNew) {} 43 CrxUpdateItem::CrxUpdateItem() : state(ComponentState::kNew) {}
45 44
46 CrxUpdateItem::~CrxUpdateItem() { 45 CrxUpdateItem::~CrxUpdateItem() {
47 } 46 }
48 47
49 CrxUpdateItem::CrxUpdateItem(const CrxUpdateItem& other) = default; 48 CrxUpdateItem::CrxUpdateItem(const CrxUpdateItem& other) = default;
(...skipping 21 matching lines...) Expand all
71 CrxDownloader::Factory crx_downloader_factory) 70 CrxDownloader::Factory crx_downloader_factory)
72 : is_stopped_(false), 71 : is_stopped_(false),
73 config_(config), 72 config_(config),
74 ping_manager_(std::move(ping_manager)), 73 ping_manager_(std::move(ping_manager)),
75 update_engine_(base::MakeUnique<UpdateEngine>( 74 update_engine_(base::MakeUnique<UpdateEngine>(
76 config, 75 config,
77 update_checker_factory, 76 update_checker_factory,
78 crx_downloader_factory, 77 crx_downloader_factory,
79 ping_manager_.get(), 78 ping_manager_.get(),
80 base::Bind(&UpdateClientImpl::NotifyObservers, 79 base::Bind(&UpdateClientImpl::NotifyObservers,
81 base::Unretained(this)))) { 80 base::Unretained(this)))) {}
82 // Temporary change while investigating crbug.com/717889.
83 xmlInitParser();
84 }
85 81
86 UpdateClientImpl::~UpdateClientImpl() { 82 UpdateClientImpl::~UpdateClientImpl() {
87 DCHECK(thread_checker_.CalledOnValidThread()); 83 DCHECK(thread_checker_.CalledOnValidThread());
88 84
89 DCHECK(task_queue_.empty()); 85 DCHECK(task_queue_.empty());
90 DCHECK(tasks_.empty()); 86 DCHECK(tasks_.empty());
91 87
92 config_ = nullptr; 88 config_ = nullptr;
93 } 89 }
94 90
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 return base::MakeShared<UpdateClientImpl>( 242 return base::MakeShared<UpdateClientImpl>(
247 config, base::MakeUnique<PingManager>(config), &UpdateChecker::Create, 243 config, base::MakeUnique<PingManager>(config), &UpdateChecker::Create,
248 &CrxDownloader::Create); 244 &CrxDownloader::Create);
249 } 245 }
250 246
251 void RegisterPrefs(PrefRegistrySimple* registry) { 247 void RegisterPrefs(PrefRegistrySimple* registry) {
252 PersistedData::RegisterPrefs(registry); 248 PersistedData::RegisterPrefs(registry);
253 } 249 }
254 250
255 } // namespace update_client 251 } // namespace update_client
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698