Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.h

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Fix Windows Compilation Error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/credential_manager_impl.h
diff --git a/components/password_manager/content/browser/credential_manager_impl.h b/components/password_manager/content/browser/credential_manager_impl.h
index 9694627d07c7b49b2c654e835cb6ac78ccfbc795..e4d49b585a3437cab3458dfa825caaa4276aeff4 100644
--- a/components/password_manager/content/browser/credential_manager_impl.h
+++ b/components/password_manager/content/browser/credential_manager_impl.h
@@ -15,6 +15,7 @@
#include "components/password_manager/core/browser/credential_manager_pending_request_task.h"
#include "components/password_manager/core/browser/credential_manager_pending_require_user_mediation_task.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
+#include "components/password_manager/core/common/credential_manager_types.h"
#include "components/prefs/pref_member.h"
#include "content/public/browser/web_contents_observer.h"
#include "mojo/public/cpp/bindings/binding_set.h"
@@ -52,7 +53,7 @@ class CredentialManagerImpl
// mojom::CredentialManager methods:
void Store(const CredentialInfo& credential, StoreCallback callback) override;
void RequireUserMediation(RequireUserMediationCallback callback) override;
- void Get(bool zero_click_only,
+ void Get(mojom::CredentialMediationRequirement mediation,
vasilii 2017/05/18 12:34:03 Can we use only the enum declared in credential_ma
jdoerrie 2017/05/18 14:57:24 Done, this required entries in components/passwor
bool include_passwords,
const std::vector<GURL>& federations,
GetCallback callback) override;
@@ -87,6 +88,10 @@ class CredentialManagerImpl
// Set to false to disable automatic signing in.
BooleanPrefMember auto_signin_enabled_;
+ // Set during |Get|, needed to log the correct result during
+ // |SendPasswordForm|.
+ CredentialMediationRequirement mediation_;
+
// When 'OnRequestCredential' is called, it in turn calls out to the
// PasswordStore; we push enough data into Pending*Task objects so that
// they can properly respond to the request once the PasswordStore gives

Powered by Google App Engine
This is Rietveld 408576698