Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.h

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_pending_request_task.h
diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.h b/components/password_manager/core/browser/credential_manager_pending_request_task.h
index a444a723130cb41dfb817011cf7143cecdd000fa..6c31ab0cbac99a4a937ee33983d7c05a0eacf7e6 100644
--- a/components/password_manager/core/browser/credential_manager_pending_request_task.h
+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.h
@@ -15,6 +15,7 @@
#include "components/password_manager/core/browser/http_password_store_migrator.h"
#include "components/password_manager/core/browser/password_store.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
+#include "components/password_manager/core/common/credential_manager_types.h"
#include "url/gurl.h"
namespace autofill {
@@ -49,6 +50,7 @@ class CredentialManagerPendingRequestTaskDelegate {
// Updates |skip_zero_click| for |form| in the PasswordStore if required.
// Sends a credential to JavaScript.
virtual void SendPasswordForm(const SendCredentialCallback& send_callback,
+ CredentialMediationRequirement mediation,
const autofill::PasswordForm* form) = 0;
};
@@ -60,7 +62,7 @@ class CredentialManagerPendingRequestTask
CredentialManagerPendingRequestTask(
CredentialManagerPendingRequestTaskDelegate* delegate,
const SendCredentialCallback& callback,
- bool request_zero_click_only,
+ CredentialMediationRequirement mediation,
bool include_passwords,
const std::vector<GURL>& request_federations);
~CredentialManagerPendingRequestTask() override;
@@ -82,7 +84,7 @@ class CredentialManagerPendingRequestTask
CredentialManagerPendingRequestTaskDelegate* delegate_; // Weak;
SendCredentialCallback send_callback_;
- const bool zero_click_only_;
+ const CredentialMediationRequirement mediation_;
const GURL origin_;
const bool include_passwords_;
std::set<std::string> federations_;

Powered by Google App Engine
This is Rietveld 408576698