Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: components/password_manager/content/renderer/credential_manager_client_browsertest.cc

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/renderer/credential_manager_client_browsertest.cc
diff --git a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
index caa9f9ca6f7b13345245409a5e03531796b23c3e..c539e85efaf73d508cf1dded5ac85963f11f906f 100644
--- a/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
+++ b/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
@@ -24,6 +24,7 @@
#include "third_party/WebKit/public/platform/WebCredential.h"
#include "third_party/WebKit/public/platform/WebCredentialManagerClient.h"
#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"
+#include "third_party/WebKit/public/platform/WebCredentialMediationRequirement.h"
#include "third_party/WebKit/public/platform/WebPasswordCredential.h"
namespace password_manager {
@@ -54,7 +55,7 @@ class FakeCredentialManager : public mojom::CredentialManager {
std::move(callback).Run();
}
- void Get(bool zero_click_only,
+ void Get(CredentialMediationRequirement mediation,
bool include_passwords,
const std::vector<GURL>& federations,
GetCallback callback) override {
@@ -208,7 +209,8 @@ TEST_F(CredentialManagerClientTest, SendRequestCredential) {
new TestRequestCallbacks(this));
std::vector<GURL> federations;
federations.push_back(GURL(kTestCredentialPassword));
- client_->DispatchGet(false, true, federations, callbacks.release());
+ client_->DispatchGet(blink::WebCredentialMediationRequirement::kOptional,
+ true, federations, callbacks.release());
RunAllPendingTasks();
@@ -223,7 +225,8 @@ TEST_F(CredentialManagerClientTest, SendRequestCredentialEmpty) {
new TestRequestCallbacks(this));
std::vector<GURL> federations;
federations.push_back(GURL(kTestCredentialEmpty));
- client_->DispatchGet(false, true, federations, callbacks.release());
+ client_->DispatchGet(blink::WebCredentialMediationRequirement::kOptional,
+ true, federations, callbacks.release());
RunAllPendingTasks();
@@ -237,7 +240,8 @@ TEST_F(CredentialManagerClientTest, SendRequestCredentialReject) {
new TestRequestCallbacks(this));
std::vector<GURL> federations;
federations.push_back(GURL(kTestCredentialReject));
- client_->DispatchGet(false, true, federations, callbacks.release());
+ client_->DispatchGet(blink::WebCredentialMediationRequirement::kOptional,
+ true, federations, callbacks.release());
RunAllPendingTasks();

Powered by Google App Engine
This is Rietveld 408576698