components/password_manager/content/renderer/credential_manager_client.h - Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_struct_traits.cc ('k') | components/password_manager/content/renderer/credential_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index 388ed941ec85165084d9c5da10e7e8da2a5b09fb..d623a42d8136f883fe44ed04e395fb3e7de48498 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -11,6 +11,7 @@

#include "content/public/renderer/render_view_observer.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerClient.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"

+#include "third_party/WebKit/public/platform/WebCredentialMediationRequirement.h"

#include "third_party/WebKit/public/platform/WebVector.h"

namespace blink {

@@ -47,7 +48,7 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

const blink::WebCredential& credential,

WebCredentialManagerClient::NotificationCallbacks* callbacks) override;

void DispatchRequireUserMediation(NotificationCallbacks* callbacks) override;

- void DispatchGet(bool zero_click_only,

+ void DispatchGet(blink::WebCredentialMediationRequirement mediation,

bool include_passwords,

const blink::WebVector<blink::WebURL>& federations,

RequestCallbacks* callbacks) override;