Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.cc

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/credential_manager_impl.cc
diff --git a/components/password_manager/content/browser/credential_manager_impl.cc b/components/password_manager/content/browser/credential_manager_impl.cc
index 2b93023d44a65918ded02bf99e64eea2523aaea4..7169623589bd11ecc63b73e40f163a17e46050ac 100644
--- a/components/password_manager/content/browser/credential_manager_impl.cc
+++ b/components/password_manager/content/browser/credential_manager_impl.cc
@@ -22,7 +22,6 @@
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/browser/password_manager_util.h"
#include "components/password_manager/core/browser/password_store.h"
-#include "components/password_manager/core/common/credential_manager_types.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "content/public/browser/web_contents.h"
@@ -146,19 +145,17 @@ void CredentialManagerImpl::RequireUserMediation(
pending_require_user_mediation_->AddOrigin(GetSynthesizedFormForOrigin());
}
-void CredentialManagerImpl::Get(bool zero_click_only,
+void CredentialManagerImpl::Get(CredentialMediationRequirement mediation,
bool include_passwords,
const std::vector<GURL>& federations,
GetCallback callback) {
using metrics_util::LogCredentialManagerGetResult;
- metrics_util::CredentialManagerGetMediation mediation_status =
- zero_click_only ? metrics_util::CREDENTIAL_MANAGER_GET_UNMEDIATED
- : metrics_util::CREDENTIAL_MANAGER_GET_MEDIATED;
+
PasswordStore* store = GetPasswordStore();
if (password_manager_util::IsLoggingActive(client_)) {
CredentialManagerLogger(client_->GetLogManager())
- .LogRequestCredential(web_contents()->GetLastCommittedURL(),
- zero_click_only, federations);
+ .LogRequestCredential(web_contents()->GetLastCommittedURL(), mediation,
+ federations);
}
if (pending_request_ || !store) {
// Callback error.
@@ -168,7 +165,7 @@ void CredentialManagerImpl::Get(bool zero_click_only,
: mojom::CredentialManagerError::PASSWORDSTOREUNAVAILABLE,
base::nullopt);
LogCredentialManagerGetResult(metrics_util::CREDENTIAL_MANAGER_GET_REJECTED,
- mediation_status);
+ mediation);
return;
}
@@ -179,23 +176,23 @@ void CredentialManagerImpl::Get(bool zero_click_only,
std::move(callback).Run(mojom::CredentialManagerError::SUCCESS,
CredentialInfo());
LogCredentialManagerGetResult(metrics_util::CREDENTIAL_MANAGER_GET_NONE,
- mediation_status);
+ mediation);
return;
}
// Return an empty credential if zero-click is required but disabled.
- if (zero_click_only && !IsZeroClickAllowed()) {
+ if (mediation == CredentialMediationRequirement::kSilent &&
+ !IsZeroClickAllowed()) {
// Callback with empty credential info.
std::move(callback).Run(mojom::CredentialManagerError::SUCCESS,
CredentialInfo());
LogCredentialManagerGetResult(
- metrics_util::CREDENTIAL_MANAGER_GET_NONE_ZERO_CLICK_OFF,
- mediation_status);
+ metrics_util::CREDENTIAL_MANAGER_GET_NONE_ZERO_CLICK_OFF, mediation);
return;
}
pending_request_.reset(new CredentialManagerPendingRequestTask(
- this, base::Bind(&RunMojoGetCallback, base::Passed(&callback)),
- zero_click_only, include_passwords, federations));
+ this, base::Bind(&RunMojoGetCallback, base::Passed(&callback)), mediation,
+ include_passwords, federations));
// This will result in a callback to
// PendingRequestTask::OnGetPasswordStoreResults().
GetPasswordStore()->GetLogins(GetSynthesizedFormForOrigin(),
@@ -235,6 +232,7 @@ void CredentialManagerImpl::SendCredential(
void CredentialManagerImpl::SendPasswordForm(
const SendCredentialCallback& send_callback,
+ CredentialMediationRequirement mediation,
const autofill::PasswordForm* form) {
CredentialInfo info;
if (form) {
@@ -253,14 +251,12 @@ void CredentialManagerImpl::SendPasswordForm(
base::RecordAction(
base::UserMetricsAction("CredentialManager_AccountChooser_Accepted"));
metrics_util::LogCredentialManagerGetResult(
- metrics_util::CREDENTIAL_MANAGER_GET_ACCOUNT_CHOOSER,
- metrics_util::CREDENTIAL_MANAGER_GET_MEDIATED);
+ metrics_util::CREDENTIAL_MANAGER_GET_ACCOUNT_CHOOSER, mediation);
} else {
base::RecordAction(
base::UserMetricsAction("CredentialManager_AccountChooser_Dismissed"));
metrics_util::LogCredentialManagerGetResult(
- metrics_util::CREDENTIAL_MANAGER_GET_NONE,
- metrics_util::CREDENTIAL_MANAGER_GET_MEDIATED);
+ metrics_util::CREDENTIAL_MANAGER_GET_NONE, mediation);
}
SendCredential(send_callback, info);
}

Powered by Google App Engine
This is Rietveld 408576698