Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: kOptional, no RuntimeEnabled and Test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl
diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl b/third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl
index 0e5902aaa632ccedb4299e0618a037d93f7767fc..6fee4cfc4e4dedba07aa70e0cb79bbdcf8e22004 100644
--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl
+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialRequestOptions.idl
@@ -2,11 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// https://w3c.github.io/webappsec/specs/credentialmanagement/#dictdef-credentialrequestoptions
+// https://w3c.github.io/webappsec-credential-management/#dictdef-credentialrequestoptions
+
+enum CredentialMediationRequirement {
+ "silent",
+ "optional",
+ "required"
+};
dictionary CredentialRequestOptions {
FederatedCredentialRequestOptions federated;
boolean password = false;
- boolean unmediated = false;
+ // Defaults to false. This is not set here to detect when both 'unmediated'
+ // and 'mediation' are user provided, which results in an error.
+ [DeprecateAs=CredentialManagerCredentialRequestOptionsUnmediated] boolean
+ unmediated;
+ // Defaults to "optional". This is not set here to detect when both
+ // 'unmediated' and 'mediation' are user provided, which results in an
+ // error.
+ // TODO(http://crbug.com/715077): Set the default here when 'unmediated' is
+ // removed.
+ CredentialMediationRequirement mediation;
};

Powered by Google App Engine
This is Rietveld 408576698