Deprecate CredentialRequestOptions.unmediated in favor mediation enum

third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/credentialmanager/CredentialsContainer.h"
 
 #include <memory>
 #include <utility>
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/frame/Frame.h"
 #include "core/frame/UseCounter.h"
+#include "core/inspector/ConsoleMessage.h"
 #include "core/page/FrameTree.h"
 #include "modules/credentialmanager/Credential.h"
 #include "modules/credentialmanager/CredentialManagerClient.h"
 #include "modules/credentialmanager/CredentialRequestOptions.h"
 #include "modules/credentialmanager/FederatedCredential.h"
 #include "modules/credentialmanager/FederatedCredentialRequestOptions.h"
 #include "modules/credentialmanager/PasswordCredential.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "platform/wtf/PtrUtil.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebCredential.h"
 #include "public/platform/WebCredentialManagerClient.h"
 #include "public/platform/WebCredentialManagerError.h"
+#include "public/platform/WebCredentialMediationRequirement.h"
 #include "public/platform/WebFederatedCredential.h"
 #include "public/platform/WebPasswordCredential.h"
 
 namespace blink {
 
 static void RejectDueToCredentialManagerError(
     ScriptPromiseResolver* resolver,
     WebCredentialManagerError reason) {
   switch (reason) {
     case kWebCredentialManagerDisabledError:
@@ skipping 120 matching lines @@
 }
 
 ScriptPromise CredentialsContainer::get(
     ScriptState* script_state,
     const CredentialRequestOptions& options) {
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::Create(script_state);
   ScriptPromise promise = resolver->Promise();
   if (!CheckBoilerplate(resolver))
     return promise;
 
+  ExecutionContext* context = ExecutionContext::From(script_state);
+  // Set the default mediation option if none is provided.
+  // If both 'unmediated' and 'mediation' are set log a warning if they are
+  // contradicting.
+  // Also sets 'mediation' appropriately when only 'unmediated' is set.
+  // TODO(http://crbug.com/715077): Remove this when 'unmediated' is removed.
+  String mediation = "optional";
+  if (options.hasUnmediated() && !options.hasMediation()) {
+    mediation = options.unmediated() ? "silent" : "optional";
+  } else if (options.hasMediation()) {
+    mediation = options.mediation();

[Mike West, 2017/05/19 15:29:56]

Please add a test for invalid values.

[jdoerrie, 2017/05/19 16:22:37]

That already exists in credentialscontainer-get-errors.html, no?
Or do you mean a test for something else?

+    if (options.hasUnmediated() &&
+        ((options.unmediated() && options.mediation() != "silent") ||
+         (!options.unmediated() && options.mediation() != "optional"))) {
+      context->AddConsoleMessage(ConsoleMessage::Create(
+          kJSMessageSource, kWarningMessageLevel,
+          "mediation: '" + options.mediation() + "' overrides unmediated: " +
+              (options.unmediated() ? "true" : "false") + "."));

[Mike West, 2017/05/19 15:29:57]

Please add a test for this behavior.

[jdoerrie, 2017/05/19 16:22:37]

Done, please see 
credentialscontainer-get-warnings.html and
credentialscontainer-get-warnings-expected.txt

+    }
+  }
+
   Vector<KURL> providers;
   if (options.hasFederated() && options.federated().hasProviders()) {
     for (const auto& string : options.federated().providers()) {
       KURL url = KURL(KURL(), string);
       if (url.IsValid())
         providers.push_back(std::move(url));
     }
   }
 
-  UseCounter::Count(ExecutionContext::From(script_state),
-                    options.unmediated()
-                        ? UseCounter::kCredentialManagerGetWithoutUI
-                        : UseCounter::kCredentialManagerGetWithUI);
+  UseCounter::Feature feature;
+  WebCredentialMediationRequirement requirement;
 
-  CredentialManagerClient::From(ExecutionContext::From(script_state))
-      ->DispatchGet(options.unmediated(), options.password(), providers,
-                    new RequestCallbacks(resolver));
+  if (mediation == "silent") {
+    feature = UseCounter::kCredentialManagerGetMediationSilent;
+    requirement = WebCredentialMediationRequirement::kSilent;
+  } else if (mediation == "optional") {
+    feature = UseCounter::kCredentialManagerGetMediationOptional;
+    requirement = WebCredentialMediationRequirement::kOptional;
+  } else {
+    DCHECK_EQ("required", mediation);
+    feature = UseCounter::kCredentialManagerGetMediationRequired;
+    requirement = WebCredentialMediationRequirement::kRequired;
+  }
+
+  UseCounter::Count(context, feature);

[Mike West, 2017/05/19 15:29:57]

Optional nit: I think it's simpler to just call `Count()` in the if blocks
above.

[jdoerrie, 2017/05/19 16:22:37]

Done.

+
+  CredentialManagerClient::From(context)->DispatchGet(
+      requirement, options.password(), providers,
+      new RequestCallbacks(resolver));
   return promise;
 }
 
 ScriptPromise CredentialsContainer::store(ScriptState* script_state,
                                           Credential* credential) {
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::Create(script_state);
   ScriptPromise promise = resolver->Promise();
   if (!CheckBoilerplate(resolver))
     return promise;
 
@@ skipping 10 matching lines @@
   ScriptPromise promise = resolver->Promise();
   if (!CheckBoilerplate(resolver))
     return promise;
 
   CredentialManagerClient::From(ExecutionContext::From(script_state))
       ->DispatchRequireUserMediation(new NotificationCallbacks(resolver));
   return promise;
 }
 
 }  // namespace blink