Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: components/autofill/core/browser/autofill_profile_comparator.h

Issue 2864483005: Uses AutofillProfileComparator to compare profile names. (Closed)
Patch Set: Reorder method definitions to match declaration order. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_profile_comparator.h
diff --git a/components/autofill/core/browser/autofill_profile_comparator.h b/components/autofill/core/browser/autofill_profile_comparator.h
index 8222c53e5f882821306050a552f5a6ade920e4f6..b71c4fb3d9fa7da9704aceac473842a25770c22f 100644
--- a/components/autofill/core/browser/autofill_profile_comparator.h
+++ b/components/autofill/core/browser/autofill_profile_comparator.h
@@ -59,6 +59,19 @@ class AutofillProfileComparator {
const AutofillProfile& p2,
NameInfo* name_info) const;
+ // Returns true if |full_name_2| is a variant of |full_name_1|.
+ //
+ // This function generates all variations of |full_name_1| and returns true if
+ // one of these variants is equal to |full_name_2|. For example, this function
+ // will return true if |full_name_2| is "john q public" and |full_name_1| is
+ // "john quincy public" because |full_name_2| can be derived from
+ // |full_name_1| by using the middle initial. Note that the reverse is not
+ // true, "john quincy public" is not a name variant of "john q public".
+ //
+ // Note: Expects that |full_name| is already normalized for comparison.
+ bool IsNameVariantOf(const base::string16& full_name_1,
+ const base::string16& full_name_2) const;
+
// Populates |email_info| with the result of merging the email addresses in
// |p1| and |p2|. Returns true if successful. Expects that |p1| and |p2| have
// already been found to be mergeable.
@@ -137,19 +150,6 @@ class AutofillProfileComparator {
static std::set<base::string16> GetNamePartVariants(
const base::string16& name_part);
- // Returns true if |full_name_2| is a variant of |full_name_1|.
- //
- // This function generates all variations of |full_name_1| and returns true if
- // one of these variants is equal to |full_name_2|. For example, this function
- // will return true if |full_name_2| is "john q public" and |full_name_1| is
- // "john quincy public" because |full_name_2| can be derived from
- // |full_name_1| by using the middle initial. Note that the reverse is not
- // true, "john quincy public" is not a name variant of "john q public".
- //
- // Note: Expects that |full_name| is already normalized for comparison.
- bool IsNameVariantOf(const base::string16& full_name_1,
- const base::string16& full_name_2) const;
-
// Returns true if |p1| and |p2| have names which are equivalent for the
// purposes of merging the two profiles. This means one of the names is
// empty, the names are the same, or one name is a variation of the other.

Powered by Google App Engine
This is Rietveld 408576698