Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: components/exo/shell_surface.cc

Issue 2864433004: Do not disable minimize animation for maximized/fullscreened exo windows (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/shell_surface.cc
diff --git a/components/exo/shell_surface.cc b/components/exo/shell_surface.cc
index 8bc19723cf02e8835800ffd3246ea7d3af051318..1fcd403ddce18acb12b8785ba1ed11723ca519a4 100644
--- a/components/exo/shell_surface.cc
+++ b/components/exo/shell_surface.cc
@@ -922,6 +922,11 @@ void ShellSurface::OnPreWindowStateTypeChange(
ash::wm::WindowState* window_state,
ash::wm::WindowStateType old_type) {
ash::wm::WindowStateType new_type = window_state->GetStateType();
+ if (old_type == ash::wm::WINDOW_STATE_TYPE_MINIMIZED ||
+ new_type == ash::wm::WINDOW_STATE_TYPE_MINIMIZED) {
+ return;
+ }
+
if (ash::wm::IsMaximizedOrFullscreenOrPinnedWindowStateType(old_type) ||
ash::wm::IsMaximizedOrFullscreenOrPinnedWindowStateType(new_type)) {
// When transitioning in/out of maximized or fullscreen mode we need to
@@ -929,7 +934,6 @@ void ShellSurface::OnPreWindowStateTypeChange(
// cross-fade animations. The configure callback provides a mechanism for
// the client to inform us that a frame has taken the state change into
// account and without this cross-fade animations are unreliable.
-
// TODO(domlaskowski): For BoundsMode::CLIENT, the configure callback does
// not yet support window state changes. See crbug.com/699746.
if (configure_callback_.is_null() || bounds_mode_ == BoundsMode::CLIENT)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698