Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: vpython/venv/venv.go

Issue 2864423002: vpython: Leave "pip" and related tools. (Closed)
Patch Set: fix word Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vpython/venv/config.go ('k') | vpython/venv/venv_resources_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vpython/venv/venv.go
diff --git a/vpython/venv/venv.go b/vpython/venv/venv.go
index 9c137bca0884d85c1fcaae0a902f434362ec0924..8510bf2e4b8e9682a0810b86ba87a0b9cb9a99e3 100644
--- a/vpython/venv/venv.go
+++ b/vpython/venv/venv.go
@@ -29,6 +29,10 @@ import (
"github.com/luci/luci-go/common/system/filesystem"
)
+// EnvironmentVersion is an environment version string. It must advance each
+// time the layout of a VirtualEnv environment changes.
+const EnvironmentVersion = "v1"
+
// ErrNotComplete is a sentinel error returned by AssertCompleteAndLoad to
// indicate that the Environment is missing its completion flag.
var ErrNotComplete = errors.New("environment is not complete")
@@ -616,21 +620,6 @@ func (e *Env) installWheels(c context.Context, bootstrapDir, pkgDir string) erro
}
func (e *Env) finalize(c context.Context) error {
- // Uninstall "pip" and "wheel", preventing (easy) augmentation of the
- // environment.
- if !e.Config.testPreserveInstallationCapability {
- cmd := e.Interpreter().IsolatedCommand(c,
- "-m", "pip",
- "uninstall",
- "--quiet",
- "--yes",
- "pip", "wheel")
- attachOutputForLogging(c, logging.Debug, cmd)
- if err := cmd.Run(); err != nil {
- return errors.Annotate(err).Reason("failed to install wheels").Err()
- }
- }
-
// Change all files to read-only, except:
// - Our root directory, which must be writable in order to update our
// completion flag.
« no previous file with comments | « vpython/venv/config.go ('k') | vpython/venv/venv_resources_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698