Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2864413004: Reformat third_party/WebKit/Source/platform/wtf/dtoa/. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
Nico, dcheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat third_party/WebKit/Source/platform/wtf/dtoa/. * add "// clang-format o*" to strtod.cc * run |clang-format -i *.{cc,h}|. This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2864413004 Cr-Commit-Position: refs/heads/master@{#470920} Committed: https://chromium.googlesource.com/chromium/src/+/189175d925250f4c940e246d42cfa7e188047c4a

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add "// clang-format off/on" #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3500 lines, -3501 lines) Patch
M third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc View 1 chunk +718 lines, -725 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc View 1 chunk +630 lines, -608 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/cached-powers.cc View 1 chunk +150 lines, -148 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/diy-fp.cc View 1 chunk +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc View 1 chunk +532 lines, -541 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.cc View 1 chunk +689 lines, -698 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc View 1 2 1 chunk +361 lines, -361 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc View 1 1 chunk +397 lines, -397 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
tkent
thankis@ or dcheng@, would you stamp this please? This CL has no manual changes.
3 years, 7 months ago (2017-05-09 08:08:17 UTC) #4
Nico
lgtm We also have base/third_party/dmg_fp – I wonder if we could merge the two now. ...
3 years, 7 months ago (2017-05-09 13:43:11 UTC) #7
dcheng
LGTM. I'm surprised at how well the comments ended up formatted, but I guess this ...
3 years, 7 months ago (2017-05-10 05:01:39 UTC) #8
tkent
https://codereview.chromium.org/2864413004/diff/1/third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc File third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc (left): https://codereview.chromium.org/2864413004/diff/1/third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc#oldcode84 third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc:84: 10000000000000000000000.0 On 2017/05/10 at 05:01:39, dcheng wrote: > On ...
3 years, 7 months ago (2017-05-10 22:58:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864413004/20001
3 years, 7 months ago (2017-05-10 22:59:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/441315)
3 years, 7 months ago (2017-05-11 01:24:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864413004/20001
3 years, 7 months ago (2017-05-11 04:18:02 UTC) #17
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc: While running git apply --index -3 -p1; error: patch ...
3 years, 7 months ago (2017-05-11 06:21:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864413004/40001
3 years, 7 months ago (2017-05-11 08:05:43 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 11:37:16 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/189175d925250f4c940e246d42cf...

Powered by Google App Engine
This is Rietveld 408576698