third_party/WebKit/Source/modules/vr/VRDisplay.cpp - Issue 2864363005: Prevents exiting presentation if triggering DON while presenting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Issue 2864363005: Prevents exiting presentation if triggering DON while presenting. (Closed)

Patch Set: Changed parameter to underscore case Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

index 31fbc5f152979223fcafbeaa97bdcbe2648c76b2..0ddc978ed543a5a419e35d2593a8e1f12926e448 100644

--- a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

@@ -685,7 +685,7 @@ void VRDisplay::OnActivate(device::mojom::blink::VRDisplayEventReason reason,

AutoReset<bool> activating(&in_display_activate_, true);

navigator_vr_->DispatchVREvent(VRDisplayEvent::Create(

EventTypeNames::vrdisplayactivate, true, false, this, reason));

- on_handled.Run(pending_present_request_);

+ on_handled.Run(!pending_present_request_ && !is_presenting_);

}

void VRDisplay::OnDeactivate(

« no previous file with comments | « device/vr/vr_service.mojom ('k') | no next file » | no next file with comments »