device/vr/vr_service.mojom - Issue 2864363005: Prevents exiting presentation if triggering DON while presenting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/vr_service.mojom

Issue 2864363005: Prevents exiting presentation if triggering DON while presenting. (Closed)

Patch Set: Incorporated review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/vr_service.mojom

diff --git a/device/vr/vr_service.mojom b/device/vr/vr_service.mojom

index ad9544c7d3c477da3b16648a0e285b1072aee62c..558e41099cafec73e47d6c7d85857d0468483893 100644

--- a/device/vr/vr_service.mojom

+++ b/device/vr/vr_service.mojom

@@ -115,6 +115,6 @@ interface VRDisplayClient {

OnExitPresent();

OnBlur();

OnFocus();

- OnActivate(VRDisplayEventReason reason) => (bool presentRequested);

+ OnActivate(VRDisplayEventReason reason) => (bool willNotPresent);

dcheng 2017/05/22 21:09:44 nit: will_not_present (Or consider using an enum,

tiborg 2017/05/23 16:00:12 All other parameter names in this file are camel-c

tiborg 2017/05/24 17:53:32 As discussed offline, new parameters should be und

OnDeactivate(VRDisplayEventReason reason);

};