Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: tests/compiler/dart2js/metadata_test.dart

Issue 2864363002: Remove DartString from constants. (Closed)
Patch Set: Remove toDartString Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/metadata_test.dart
diff --git a/tests/compiler/dart2js/metadata_test.dart b/tests/compiler/dart2js/metadata_test.dart
index 2b3e796e2c03b89bea3482e9e20dc2381a9f3b72..bcf9ef52e9bc0db1a187c4704e16d87d4dea83a8 100644
--- a/tests/compiler/dart2js/metadata_test.dart
+++ b/tests/compiler/dart2js/metadata_test.dart
@@ -41,7 +41,7 @@ void checkAnnotation(String name, String declaration,
annotation.ensureResolved(compiler.resolution);
PrimitiveConstantValue value =
compiler.constants.getConstantValue(annotation.constant);
- Expect.stringEquals('xyz', value.primitiveValue.slowToString());
+ Expect.stringEquals('xyz', value.primitiveValue);
checkPosition(
annotation, annotation.cachedNode, source1, compiler.reporter);
@@ -69,8 +69,8 @@ void checkAnnotation(String name, String declaration,
PrimitiveConstantValue value2 =
compiler.constants.getConstantValue(annotation2.constant);
Expect.identical(value1, value2, 'expected same compile-time constant');
- Expect.stringEquals('xyz', value1.primitiveValue.slowToString());
- Expect.stringEquals('xyz', value2.primitiveValue.slowToString());
+ Expect.stringEquals('xyz', value1.primitiveValue);
+ Expect.stringEquals('xyz', value2.primitiveValue);
checkPosition(
annotation1, annotation1.cachedNode, source2, compiler.reporter);
@@ -100,7 +100,7 @@ void checkAnnotation(String name, String declaration,
annotation.ensureResolved(compiler.resolution);
PrimitiveConstantValue value =
compiler.constants.getConstantValue(annotation.constant);
- Expect.stringEquals('xyz', value.primitiveValue.slowToString());
+ Expect.stringEquals('xyz', value.primitiveValue);
checkPosition(
annotation, annotation.cachedNode, source3, compiler.reporter);
@@ -134,8 +134,8 @@ void checkAnnotation(String name, String declaration,
PrimitiveConstantValue value2 =
compiler.constants.getConstantValue(annotation2.constant);
Expect.identical(value1, value2, 'expected same compile-time constant');
- Expect.stringEquals('xyz', value1.primitiveValue.slowToString());
- Expect.stringEquals('xyz', value2.primitiveValue.slowToString());
+ Expect.stringEquals('xyz', value1.primitiveValue);
+ Expect.stringEquals('xyz', value2.primitiveValue);
checkPosition(
annotation1, annotation1.cachedNode, source4, compiler.reporter);
@@ -184,7 +184,7 @@ void testLibraryTags() {
annotation.ensureResolved(compiler.resolution);
PrimitiveConstantValue value =
compiler.constants.getConstantValue(annotation.constant);
- Expect.stringEquals('xyz', value.primitiveValue.slowToString());
+ Expect.stringEquals('xyz', value.primitiveValue);
checkPosition(
annotation, annotation.cachedNode, source, compiler.reporter);
« no previous file with comments | « tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698