pkg/compiler/lib/src/resolution/members.dart - Issue 2864363002: Remove DartString from constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2864363002: Remove DartString from constants. (Closed)

Patch Set: Remove toDartString Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/members.dart

diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart

index 9e219277dd6e2284a7c0b6c591167903142ba070..f8742591e2afffb75565fef0c5385445bb24d29f 100644

--- a/pkg/compiler/lib/src/resolution/members.dart

+++ b/pkg/compiler/lib/src/resolution/members.dart

@@ -3954,7 +3954,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {

argumentNode, MessageKind.STRING_EXPECTED, {'type': type});

} else {

StringConstantValue stringConstant = name;

- String nameString = stringConstant.toDartString().slowToString();

+ String nameString = stringConstant.primitiveValue;

if (validateSymbol(argumentNode, nameString)) {

registry.registerConstSymbol(nameString);

}