Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8717)

Unified Diff: chrome/browser/prerender/prerender_manager.h

Issue 286433002: Add to the prerender history when no PrerenderContents is created. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager.h
diff --git a/chrome/browser/prerender/prerender_manager.h b/chrome/browser/prerender/prerender_manager.h
index c91322d2a6582fd4381ab758d72d01ff3fd46f08..95d78d5645568f5fa7822b476800922052a316bd 100644
--- a/chrome/browser/prerender/prerender_manager.h
+++ b/chrome/browser/prerender/prerender_manager.h
@@ -649,12 +649,13 @@ class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
void DestroyAndMarkMatchCompleteAsUsed(PrerenderContents* prerender_contents,
FinalStatus final_status);
- // Record a final status of a prerendered page in a histogram.
+ // Records the final status a prerender in the case that a PrerenderContents
+ // was never created, and also adds a PrerenderHistory entry.
// This is a helper function which will ultimately call
// RecordFinalStatusWthMatchCompleteStatus, using MATCH_COMPLETE_DEFAULT.
- void RecordFinalStatus(Origin origin,
- uint8 experiment_id,
- FinalStatus final_status) const;
+ void RecordFinalStatusWithoutCreatingPrerenderContents(
mmenke 2014/05/12 19:23:47 Open to ideas for shorter method names, but I thin
+ const GURL& url, Origin origin, uint8 experiment_id,
+ FinalStatus final_status) const;
// Returns whether prerendering is currently enabled for this manager.
// Must be called on the UI thread.
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698