Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 286433002: Add to the prerender history when no PrerenderContents is created. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
tburkard
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Add to the prerender history when no PrerenderContents is created. Without this, the net-internals prerendering tests fail when a cancel that creates a PrerenderContents is replaced with one that does not. BUG=372471 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269900

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/prerender/prerender_manager.h View 1 chunk +5 lines, -4 lines 1 comment Download
M chrome/browser/prerender/prerender_manager.cc View 4 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
https://codereview.chromium.org/286433002/diff/1/chrome/browser/prerender/prerender_manager.h File chrome/browser/prerender/prerender_manager.h (right): https://codereview.chromium.org/286433002/diff/1/chrome/browser/prerender/prerender_manager.h#newcode656 chrome/browser/prerender/prerender_manager.h:656: void RecordFinalStatusWithoutCreatingPrerenderContents( Open to ideas for shorter method names, ...
6 years, 7 months ago (2014-05-12 19:23:47 UTC) #1
mmenke
May make sense to test history + PrerenderManager a bit more, but I'm a bit ...
6 years, 7 months ago (2014-05-12 19:24:27 UTC) #2
tburkard
lgtm
6 years, 7 months ago (2014-05-12 21:00:50 UTC) #3
mmenke
On 2014/05/12 21:00:50, tburkard wrote: > lgtm Thanks!
6 years, 7 months ago (2014-05-12 21:36:30 UTC) #4
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-12 21:36:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/286433002/1
6 years, 7 months ago (2014-05-12 21:38:54 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 22:50:20 UTC) #7
Message was sent while issue was closed.
Change committed as 269900

Powered by Google App Engine
This is Rietveld 408576698