components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc - Issue 2864293003: [Offline Pages] Add a GCMAppHandler for offline page prefetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc

Issue 2864293003: [Offline Pages] Add a GCMAppHandler for offline page prefetch. (Closed)

Patch Set: Move Content Suggestions Observer to //components/offline_pages/core and modify lifetime management Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/core/prefetch/prefetch_service_impl.h ('K') | « components/offline_pages/core/prefetch/prefetch_service_impl.cc ('k') | components/offline_pages/core/prefetch/suggested_articles_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc

diff --git a/components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc b/components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc

index f2a782dc80bef32dc23fc61c138d5c0034c1788b..5dfee7429616b7f013a645adecd6220fb7b90e62 100644

--- a/components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc

+++ b/components/offline_pages/core/prefetch/prefetch_service_impl_unittest.cc

@@ -11,7 +11,7 @@

namespace offline_pages {

TEST(PrefetchServiceTest, ServiceDoesNotCrash) {

- PrefetchServiceImpl service;

+ PrefetchServiceImpl service(nullptr);

service.AddCandidatePrefetchURLs(std::vector<PrefetchService::PrefetchURL>());

service.RemoveAllUnprocessedPrefetchURLs(kSuggestedArticlesNamespace);