[Offline Pages] Add a GCMAppHandler for offline page prefetch.

components/offline_pages/core/prefetch/prefetch_service_impl.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_IMPL_H_
 #define COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_IMPL_H_
 
 #include <vector>

[fgorski, 2017/05/16 20:03:02]

#include <memory>

 
 #include "components/offline_pages/core/prefetch/prefetch_service.h"
 #include "url/gurl.h"
 
 namespace offline_pages {
 
 class PrefetchServiceImpl : public PrefetchService {
  public:
-  PrefetchServiceImpl();
+  // An interface allowing the prefetch service to hold a GCM App Handler for
+  // lifetime purposes. TODO(dewittj): Add an interface method for getting an
+  // InstandID token.
+  class GCMAppHandler {

[Dmitry Titov, 2017/05/16 19:33:23]

Does it deserve a separate file? Most of the subobjects of PS (Zine, Dispatcher,
etc) will have a separate declaration, perhaps it's better to just use one way
of creating those subobjects.

[fgorski, 2017/05/16 20:03:02]

If this is only about life cycle, why not user data?

If this is going to be extended to provide interface to the functionality I am
OK with that.

[dewittj, 2017/05/16 22:58:22]

Added TODO and left interface here.

+   public:
+    virtual ~GCMAppHandler() = default;
+  };
+
+  PrefetchServiceImpl(std::unique_ptr<GCMAppHandler> gcm_app_handler);

[fgorski, 2017/05/16 20:03:01]

explicit in case you stick with the interface

[dewittj, 2017/05/16 22:58:22]

Done.

   ~PrefetchServiceImpl() override;
 
   // PrefetchService implementation:
   void AddCandidatePrefetchURLs(
       const std::vector<PrefetchURL>& suggested_urls) override;
   void RemoveAllUnprocessedPrefetchURLs(const std::string& name_space) override;
   void RemovePrefetchURLsByClientId(const ClientId& client_id) override;
   void BeginBackgroundTask(std::unique_ptr<ScopedBackgroundTask> task) override;
   void StopBackgroundTask(ScopedBackgroundTask* task) override;
 
   // KeyedService implementation:
   void Shutdown() override;
 
  private:
+  std::unique_ptr<GCMAppHandler> gcm_app_handler_;
+
   DISALLOW_COPY_AND_ASSIGN(PrefetchServiceImpl);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_IMPL_H_