third_party/WebKit/Source/core/html/HTMLObjectElement.cpp - Issue 2864253003: Split ImageLoader::SetImage() and set flags consistently in tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Issue 2864253003: Split ImageLoader::SetImage() and set flags consistently in tests (Closed)

Patch Set: Update comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

index f17c71f3c349016e4716279a41b7e859ca0ea3ea..4cdbe2a0efdacdb77ba2958d1569a722864f4812 100644

--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

@@ -399,7 +399,7 @@ void HTMLObjectElement::RenderFallbackContent() {

if (!IsImageType()) {

// If we don't think we have an image type anymore, then clear the image

// from the loader.

- image_loader_->SetImage(0);

+ image_loader_->ClearImage();

ReattachFallbackContent();

return;

}