Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2864243004: Revert "Start using FileState/FileSystemState to provide consistent view." (Closed)

Created:
3 years, 7 months ago by erikcorry
Modified:
3 years, 7 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Start using FileState/FileSystemState to provide consistent view." This reverts commit 6173ac476bf399bd89e65ca70834642cefc31580. Failure on analyzer test: python tools/test.py -mrelease --checked -t60 --use-sdk pkg/front_end/test/subpackage_relationships_test BUG= TBR=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/de0f220b7d39f3408d76024bc7e4b108efa37a2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -297 lines) Patch
M pkg/front_end/lib/incremental_kernel_generator.dart View 1 chunk +5 lines, -3 lines 0 comments Download
D pkg/front_end/lib/src/incremental/file_state.dart View 1 chunk +0 lines, -225 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 5 chunks +4 lines, -50 lines 0 comments Download
M pkg/front_end/test/incremental_kernel_generator_test.dart View 3 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
erikcorry
3 years, 7 months ago (2017-05-09 07:21:04 UTC) #1
erikcorry
Committed patchset #1 (id:1) manually as de0f220b7d39f3408d76024bc7e4b108efa37a2c (presubmit successful).
3 years, 7 months ago (2017-05-09 07:21:31 UTC) #3
ahe
3 years, 7 months ago (2017-05-09 07:25:44 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698