Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2864233002: improve completion for formal param initializers (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 7 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 7 months ago (2017-05-08 04:23:21 UTC) #2
pquitslund
LGTM. Thanks!
3 years, 7 months ago (2017-05-08 13:44:01 UTC) #3
danrubel
3 years, 7 months ago (2017-05-08 13:50:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
959b7c14b8905664e3649acfe217dfc1e828b287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698