Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 286423002: Make adb_install_apk.py saner for humans. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_build_cleanup
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/adb_install_apk.py ('K') | « build/android/adb_install_apk.py ('k') | build/android/provision_devices.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 820074977591e681ffb5e59379565b5b32cce946..16ea4d939525f87553b6926150355319d38b4a84 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -171,9 +171,10 @@ def InstallApk(options, test, print_step=False):
if print_step:
bb_annotations.PrintNamedStep('install_%s' % test.name.lower())
- args = ['--apk', test.apk, '--apk_package', test.apk_package]
+ args = ['--apk_package', test.apk_package]
if options.target == 'Release':
args.append('--release')
+ args.append(test.apk)
RunCmd(['build/android/adb_install_apk.py'] + args, halt_on_failure=True)
« build/android/adb_install_apk.py ('K') | « build/android/adb_install_apk.py ('k') | build/android/provision_devices.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698